Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new condiment station #2637

Merged
merged 13 commits into from
Jan 4, 2025
Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Dec 30, 2024

About the PR

This PR adds a new dispenser for condiments, in addition to a dispenser for condiment cups and crafting means for each.

Big shout to @wallflowerghost for the sprite glowup.

Why / Balance

I was looking for an alternative approach to the condiment station vending machine and thought this might be a viable alternative. PLUS I needed a way to offload 1000u of ketchup, so having a way to better get the ketchup out of the barrel and into the customer's hands, even 5u at a time, seemed ideal.

How to test

Place and ensure the filled condiment machine comes stocked as desired.
Ditto condiment cups.
Ensure that all crafting recipes are functioning as desired.

Media

ss+(2024-12-30+at+10 47 00)

ss+(2024-12-30+at+11 32 48)

Requirements

Breaking changes

Changelog

🆑

  • add: Condiment dispenser.

Copy link
Contributor

github-actions bot commented Dec 30, 2024

RSI Diff Bot; head commit 2142664 merging into 079c63c
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Head/Hats/condiment_cup.rsi

State Old New Status
equipped-HELMET Added
icon Added

Resources/Textures/_NF/Objects/Consumable/Drinks/condiment_cup.rsi

State Old New Status
icon-0 Added
icon-1 Added

Resources/Textures/_NF/Objects/Specific/Service/condiment_cup_dispenser.rsi

State Old New Status
dispenser0 Added
dispenser1 Added

Resources/Textures/_NF/Structures/smalldispensers.rsi

State Old New Status
icon Added

Edit: diff updated after 2142664

@Temoffy
Copy link
Contributor

Temoffy commented Dec 30, 2024

Are those upside down helmets?

@dustylens
Copy link
Contributor Author

Nope! Unique sprites from wallflowerghost!

@Temoffy
Copy link
Contributor

Temoffy commented Dec 30, 2024

I guess it shows how well they fit in that I thought they were pre-existing sprites

@dustylens
Copy link
Contributor Author

ss+(2024-12-29+at+11 09 44)

Much nicer than my sad sprites for sure.

dvir001 and others added 2 commits January 3, 2025 15:30
Converted tag to empty comp
Removed StaticPrice to match the rest of the machines
Rebase CondimentCup to DrinkWaterCup added on head sprite
Added label to jugs
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bless

Upped from 5u to 20u since 5u is near nothing.
Lower to 10 caps to avoid entity spam

@dustylens
Copy link
Contributor Author

dustylens commented Jan 3, 2025

Bless

Upped from 5u to 20u since 5u is near nothing. Lower to 10 caps to avoid entity spam

People are meant to be pulling a condiment packet's amount to use for their food. Not chugging the stuff.

From a more practical standpoint 20u will mostly result condiments being thrown away.

Copy link
Contributor

github-actions bot commented Jan 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@dvir001 dvir001 merged commit 6d82a7b into new-frontiers-14:master Jan 4, 2025
14 checks passed
FrontierATC added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants