Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medical Dispatch POI #2451

Merged
merged 91 commits into from
Jan 21, 2025
Merged

Conversation

dustylens
Copy link
Contributor

@dustylens dustylens commented Nov 24, 2024

About the PR

This PR adds a new POI to serve as a shipyard for medical craft and a drop off point for medical bounties.

It also serves as an initial base for the Medical Operations Manager (MOM). A new whitelisted role that will serve as a testbed for rolling out medical pay systems in addition to serving as a public face for organizing medical play and incorporating new players into the field.

Why / Balance

  • Maintainer request for a new place to store medical ships and bounty drop off points.
  • Maintainer request for a place to stash a new medical director to facilitate pay.

As per request this POI offers virtually no specific services and is not, in fact, a medical center. It is a place where players may spawn in, purchase a ship and vital round start equipment and then go on their merry way. It is a gathering place for medics and a good space to find and collaborate with peers. But it is not a hospital in its default form.

The whitelisted role is currently intended to serve as a guide and to facilitate cooperation by example and via provision of basic pay to selected cooperating medics. We're going to feel this one out as time goes on and adjust based on feedback and experience.

There will be one shift Mom, but the medic roles themselves remain pilot/mercenary picks.

Currently the station has spawn in points for pilots, mercenaries and the MOM (love you mom).

There is no contractor spawn in point. This seemed appropriate as it might be more than a bit of a noob trap. Players who want to sign on with medical crews may do so through traditional means.

Mom access is currently based on the SR. This could probably be dropped to the STC based on ongoing discussion.
Mom loadouts are currently based on mercenary loadouts due to lack of specific role drip. That isn't something that I view as a blocker at present and not worth holding up the PR. CMO gear is provided in the spawn in room.

This PR is, I feel, currently at an acceptable MVP state and is worth examining for tweaks and changes to ensure that naming conventions, role permissions and other requirements are where they should be. This is a first run for me so I may have missed a few things.

The biggest to:do on my own end is largely aesthetics based. Which is going to go about as quickly as my own spiriting skills permit.

There are a lot of role and loadout changes here that are a first for me. So I anticipate that there will be some initial bugs to iron out.

How to test

Fire it up. Try spawning in. Check out the station. Check out the roles.

Media

ss+(2024-11-23+at+04 00 11)
ss+(2024-11-23+at+04 01 59)
ss+(2024-11-23+at+04 01 48)

Requirements

Breaking changes

Changelog

🆑

  • add: Added Medical Dispatch, a POI with spawn points.
  • add: Added a new whitelisted command role, the Director of Care.
  • tweak: Medical ships moved from Frontier to new medical dispatch POI.

Copy link
Contributor

github-actions bot commented Nov 24, 2024

RSI Diff Bot; head commit 54473ef merging into 80c1f3f
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Interface/Misc/job_icons.rsi

State Old New Status
nfmsdoc Added

Resources/Textures/_NF/Markers/jobs.rsi

State Old New Status
medic Added

Resources/Textures/_NF/Objects/Devices/encryption_keys.rsi

State Old New Status
cmo_label Added
crypt_silver Added

Resources/Textures/_NF/Objects/Devices/pda.rsi

State Old New Status
pda-doc Added

Resources/Textures/_NF/Objects/Misc/id_cards.rsi

State Old New Status
idmedicdoc Added

Resources/Textures/_NF/Objects/Misc/stamps.rsi

State Old New Status
stamp-doc Added

Resources/Textures/_NF/Structures/Wallmounts/memorial_sign.rsi

State Old New Status
memorial Added

Resources/Textures/_NF/Structures/Wallmounts/posters.rsi

State Old New Status
nf_poster16_contraband Added

Edit: diff updated after 54473ef

@github-actions github-actions bot added the S: Merge Conflict This PR has conflicts that prevent merging label Nov 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict This PR has conflicts that prevent merging label Nov 26, 2024
@dustylens
Copy link
Contributor Author

Where are we at?

The POI seems to be in a stable place, having made the transition across the merge in one piece.

The big outstanding piece atm is setting up a specific bank and connecting terminal.

There's a little more work to be done with loadouts, ranging to a LOT more work to be done on loadouts depending on how heavy spriting contributions go. But I see that as an iterative down the road rolling progress piece.

@dustylens
Copy link
Contributor Author

Please ask me to change all of the DoC references back to MOM.

@dustylens
Copy link
Contributor Author

Mapping and headset changes in.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good.

Changes I made that could use a double check:

  • Optional POI count reduced to 6 from 8 (could probably even be reduced to 5)
  • Medical forms reworked slightly - DOC forms have a separate header colour for easier visual ID (they're still close)
  • DOC loadouts changed - they've got a new encryption key with command, medical, and common access and a separate centcom key (only because they report directly to them - if this changes to where the SR is their boss, which I could see an argument for, fair enough)
  • "DirectorofCare" changed to "DirectorOfCare"
  • Gas mixture on Medical Dispatch fixed

Things that require some acknowledgement:

  • AllAccess is probably fine if it's a role that's at the same level as the SR - it's a whitelisted role, and gross abuse should be an administrative issue - the fact that the whitelisting process lets that through is its own problem.
  • Ditto for centcomm radio - since centcomm is their boss, I think it makes sense
  • The station admin console flatpack is to allow for the DOC, in cases where it is reasonable, to run with a ship of their choice without needing DOC-specific versions of the ship. You want to run a Spirit for whatever reason? Power to you, you can hand out payments from your ship without issue.

This looks good to me.

@github-actions github-actions bot added the Map-Outpost Map - Outpost label Jan 19, 2025
@Cheackraze
Copy link
Member

#2734 contains Medical Dispatch-specific holopads to be mapped at your descretion, 2 named ones, Reception and DoC's Office. Up to you how you use them, if they get merged before this one does in the next day or so

@dustylens
Copy link
Contributor Author

Thanks Check.

Are there any outstanding pieces to this particular puzzle or are we waiting a few days to take another look at everything to see how we feel about it.

@dustylens
Copy link
Contributor Author

Minor form updates, would appreciate a second glance.

@dvir001
Copy link
Contributor

dvir001 commented Jan 20, 2025

@dustylens
Copy link
Contributor Author

@whatston3
Copy link
Contributor

whatston3 commented Jan 20, 2025

@dvir001
Gave my piece here: #2451 (review)
Seems good to go on my side.
Wrote up an intro blurb with Dusty that seems fine to me.

Worth note: there are a few changes, particularly reducing the optional POI count, that might be undesirable to others (but seem fine to me).

@Cheackraze
Copy link
Member

i dont think we are at the limit of optional POIs anyhow since most of these being introduced lately are mandatory and shouldnt be bumping up against that limit. I also want to make a couple POIs to add a bit of variety in that specific spawn pool anyways.

@Cheackraze
Copy link
Member

i have the announcement sent to me and I'll relay it on the discord announcements after this is merged, it may or may not coincide with another announcement this afternoon/evening

@Cheackraze Cheackraze merged commit 1425277 into new-frontiers-14:master Jan 21, 2025
17 checks passed
FrontierATC added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Docs Improvements or additions to documentation FTL Map-Outpost Map - Outpost Map-POI Map - POI Map-Shuttle Map - Shuttle S: Needs Review This PR is awaiting reviews Sprites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants