Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ajusted Merc and Nfsd gear #2446

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Nov 22, 2024

About the PR

Change some of the numbers up and down to fit a more logical point.

Restore ClothingOuterArmorHeavy to upstream stats
Fix merc + security magboots to normal magboots stats, kept the sidearm.
Fixed merc vest stats to match the security armor, gave all the basic armor mini storage
Lower armor on NFSD basic armor, why was it so OP.

Why / Balance

Keeping the stats actually normal for ones without power gaming to anyside.
OQL For added storage.

How to test

Spawn the basic armor, inspect contra and stats, make sure its logical.

Media

N/A

Requirements

Breaking changes

N/A

Changelog
🆑

  • add: Added small storage on most light armor vests.
  • tweak: Matched the merc magboots stats to other of the same type.
  • tweak: Updated the NFSD basic armor to match the normal basic armor.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

RSI Diff Bot; head commit 57ef8a5 merging into 78a4933
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after 57ef8a5

@arimah
Copy link
Contributor

arimah commented Nov 22, 2024

Keeping it real.

Write a real description. I have no idea why you've made this change.

@dustylens
Copy link
Contributor

Where does this PR fit in with the plan to build a 5(ish) tier system of hardsuits/protection grades and re-balance suits across the board?

Is it meant to be a short term fix or part of that overarching goal?

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 22, 2024

Where does this PR fit in with the plan to build a 5(ish) tier system of hardsuits/protection grades and re-balance suits across the board?

Is it meant to be a short term fix or part of that overarching goal?

Not editing softsuits / hardsuits this is just to match the base none space armor.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 22, 2024
@whatston3
Copy link
Contributor

For what it's worth, also consider addressing the jackboots' speed reduction resistance on damage - either:

  1. Remove the damage slowdown resistance, reduce the price in-line with other available merc boots.
  2. Keep the damage slowdown resistance, apply (selectively? how?) to NFSD and/or pirate items.

@dvir001
Copy link
Contributor Author

dvir001 commented Nov 23, 2024

For what it's worth, also consider addressing the jackboots' speed reduction resistance on damage - either:

  1. Remove the damage slowdown resistance, reduce the price in-line with other available merc boots.
  2. Keep the damage slowdown resistance, apply (selectively? how?) to NFSD and/or pirate items.

Tbh the damage reduction buff can go on more stuff, it's not that crazy of a life changer and it's a nice to have.

I'll ask around to see if it's balance breaking.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Nov 24, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Nov 24, 2024
Comment on lines +207 to +209
Blunt: 0.2
Slash: 0.2
Piercing: 0.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like those values might be too high: 80% res with no slowdown

@BlueHNT
Copy link

BlueHNT commented Dec 11, 2024

So you're taking unique side grades and making them all identical? Also taking research magboots whose purpose is to be slightly less slow and making it the same slowdown? Aight...

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 12, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Dec 13, 2024
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BlueHNT

This comment was marked as off-topic.

@github-actions github-actions bot added Merge Conflict This PR has conflicts that prevent merging and removed Merge Conflict This PR has conflicts that prevent merging labels Dec 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Dec 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Dec 27, 2024
@github-actions github-actions bot added Merge Conflict This PR has conflicts that prevent merging and removed Merge Conflict This PR has conflicts that prevent merging labels Jan 4, 2025
Copy link
Contributor

github-actions bot commented Jan 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants