Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pseudo Code #2012

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Sep 14, 2024

About the PR

Match PseudoItemSystem and CarryingSystem with DeltaV
Update some of the old SizeAttributeSystem with new in backpack sizes.

Why / Balance

Was very weird to have humanoids take close to no storage.

Also needed for #2009 if we ever merge it

How to test

Put felinid and goblins in backpack.
Small vulp and small lizard.

Media

image

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Sep 15, 2024
@whatston3
Copy link
Contributor

image
Yes.

Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the Goblin shape into a 4x4 parallelogram, they still fit into a backpack, but are more reasonably sized compared to the felinids' 26 square kidney bean shape. Added fields for storedOffset, storedRotation, and shape into the Short/TallWhitelistComponent, and added the storedRotation to the PseudoItemComponent.

For a reason I don't currently quite understand, the angle being used for storeRotation in the PseudoItem needs to be half of what it should be. I have a feeling this is why the goblin was upside down by default. I've noted it as a bug, but as written, it works alright.

image

@dvir001
Copy link
Contributor Author

dvir001 commented Sep 16, 2024

Nooo it wasss funny

Oh well, looks fine.

@dvir001 dvir001 merged commit 3c93160 into new-frontiers-14:master Sep 16, 2024
12 checks passed
@ErhardSteinhauer
Copy link
Contributor

Still not a triangle 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants