Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Great Tiny Fan Purge #1972

Closed
wants to merge 3 commits into from
Closed

Conversation

PeccNeck
Copy link
Contributor

@PeccNeck PeccNeck commented Sep 9, 2024

About the PR

Replaces every single tiny fan on every POI, Bluespace event, and Shuttle with the new Directional Fan, with the sole exception of Stasis (handled by #1967).

This also fixes Vagabond's broken scrubber and vent (Discord) and a Cirno Day localization error.

A few ships also lacked fans beneath exterior airtight flaps; for consistency with other ships, these have been added.

I may have also gone overboard, as I also replaced the ones in walk-in freezers and on a number of (presumably) unused maps; please inform if I should revert or tweak any of these.

Why / Balance

Directional fans are cool. Also, I think this was the direction things were headed anyway. Please correct me if I'm wrong on any part of this.

The Vagabond and Cirno Day issues were also just flat-out bugs.

How to test

Spawn any shuttle or travel to any POI, and approach any exterior airlocks, and behold: Directional fans.

Requirements

  • I have read and I am following the Pull Request Guidelines. I understand that not doing so may get my pr closed at maintainer’s discretion
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: All shuttles and PoIs now use Directional Fans at airlocks
  • fix: Fixed broken pipes on NT Vagabond
  • fix: ⑨

Copy link
Contributor

github-actions bot commented Sep 9, 2024

Thank you for contributing to the Space Station 14 repository. Unfortunately, it looks like you submitted your pull request from the master branch. We suggest you follow our git usage documentation

You can move your current work from the master branch to another branch by doing git branch <branch_name and resetting the master branch.

@github-actions github-actions bot closed this Sep 9, 2024
@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map-POI Map - POI Map-Bluespace Map - Bluespace Event Map-Admin Map - For admin use No C# FTL labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FTL Map-Admin Map - For admin use Map-Bluespace Map - Bluespace Event Map-POI Map - POI Map-Shuttle Map - Shuttle No C#
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant