Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned versions as pyproject requirements #155

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Pinned versions as pyproject requirements #155

merged 5 commits into from
Jul 19, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jul 18, 2024

Short description of the changes:

pyproject.toml updated with pinned versions for some dependencies.
Also channel reordering in the environment file

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (79cc9c9) to head (a905990).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #155   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files          23       23           
  Lines        1392     1392           
=======================================
  Hits         1236     1236           
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou changed the title mantid and pyre pinned versions as requirements Pinned versions as pyproject requirements Jul 19, 2024
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The channel reordering is a very good change. I'm surprised we didn't spot it earlier.

@mpatrou mpatrou merged commit 2d99f9b into next Jul 19, 2024
5 checks passed
@mpatrou mpatrou deleted the conda_pkg_dp branch July 19, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants