Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dq for q summing #53

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Update dq for q summing #53

merged 3 commits into from
Dec 12, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Dec 11, 2024

When summing in Q, the resolution should be computed differently. The geometric part is only related to pixel size.
This PR add this to the Q-summing option. It also cleans up the output files.

@mdoucet mdoucet requested a review from backmari December 11, 2024 17:50
Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a small unit test for compute_resolution with q_summing? The code changes look fine to me.

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (b664256) to head (dbb1aea).
Report is 18 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #53      +/-   ##
==========================================
+ Coverage   83.87%   85.87%   +2.00%     
==========================================
  Files          20       20              
  Lines        2431     2478      +47     
==========================================
+ Hits         2039     2128      +89     
+ Misses        392      350      -42     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet merged commit 1cff7ed into next Dec 12, 2024
1 check passed
@mdoucet mdoucet deleted the dq-update branch December 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants