-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xorgxrdp capture changes for GFX h264 #312
Conversation
module/rdpCapture.c
Outdated
/* used for even align capture */ | ||
return rdpCapture3(clientCon, in_reg, out_rects, num_out_rects, id); | ||
case 5: /* GFX h264 */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing I might change is now that we have 5 different capture modes, defining them in a clearer enumeration with real names might be in order. It's really confusing for those who aren't ultra-familiar with the code to understand what these mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, that makes sense. I guess the function names can change too so they are not called rdpCapture0 to rdpCapture5.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, now is the time to update them!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this requires a change in XRDP too, so I think the enumeration should be defined in the shared header between XRDP and XORGXRDP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did this, it seems to have broke CI for xorgxrdp but take a look
No description provided.