-
Notifications
You must be signed in to change notification settings - Fork 213
Conversation
@edmorley
|
Thank you for working on this :-)
The existing Travis run has no Windows testing. Whilst adding this would be great longer term, I would remove it from this PR for now, and aim for parity with the Travis config before adding more. Priority number one is getting working CI back for this repo :-)
The current Travis config doesn't support publishing, so let's remove for now. Publishing also currently requires 2FA, so would require some thought (or changes to the 2FA requirement) to automate.
The |
Looks like all checks pass now https://github.com/constgen/neutrino-dev/actions/runs/652165277 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this!
Some thoughts:
- The new CI config doesn't set
CREATE_PROJECT_YARN
-- this means it's installing yarn but actually testing NPM during the run, not yarn - The new CI config only tests one package manager, when before it tested both yarn and npm for create project. Should we check both?
Enable built-in GitHub CI/CD