Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add lock parameter to Dataset.deposit #246

Merged
merged 1 commit into from
Sep 1, 2024

Conversation

neutrinoceros
Copy link
Owner

@neutrinoceros neutrinoceros commented Aug 30, 2024

Follow up to #245: releasing the GIL and not having any sort of lock to replace it degrades performance in the general case, so it seems preferable to have some locking mechanism by default (while still allowing it to be disabled, as an opt-out)

TODO:

  • evaluate the relative usefulness of supporting both per-instance and global, and choose a sane default if both should be conserved
  • doc
  • tests

@neutrinoceros neutrinoceros added this to the v2.0.0 milestone Aug 30, 2024
@neutrinoceros neutrinoceros force-pushed the enh/deposit_locking_strategy branch 2 times, most recently from fd82f42 to f6af0d1 Compare August 30, 2024 19:23
@neutrinoceros neutrinoceros changed the title ENH: add lock_strategy parameter to Dataset.deposit ENH: add lock parameter to Dataset.deposit Aug 30, 2024
@neutrinoceros neutrinoceros force-pushed the enh/deposit_locking_strategy branch 7 times, most recently from b23c441 to ee940ab Compare August 31, 2024 10:35
@neutrinoceros neutrinoceros mentioned this pull request Sep 1, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review September 1, 2024 15:16
@neutrinoceros neutrinoceros merged commit d5843d2 into main Sep 1, 2024
17 checks passed
@neutrinoceros neutrinoceros deleted the enh/deposit_locking_strategy branch September 1, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant