Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of configuration files into single file #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AcastaPaloma
Copy link
Collaborator

@AcastaPaloma AcastaPaloma commented Oct 23, 2024

These are the current configuration files for the module upon installation:

  1. classification_config.yml
  2. general_config.yml
  3. keyboard_shortcuts_config.yml
  4. label_config.yml

Pull request includes deletion of four mentioned configuration files and addition of configuration.yml which includes their contents. Includes simplification of main file.

#68 states that these files are too confusing and should be regrouped into a single configuration file modifiable by the Configuration Window upon startup of the module.

Pull request should be tested to see if any errors come from not being able to access the new configuration.yml.

@jcohenadad jcohenadad changed the title combination of configuration files into single file Combination of configuration files into single file Oct 23, 2024
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants