fixes #38 import missing packages. Removed PyQt5 import, uses qt instead #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onSelectVolumesFolderButton() method
jcohenadad
reviewed
Jul 12, 2024
| @@ -19,17 +18,58 @@ | |||
| from bids_validator import BIDSValidator | |||
| import filecmp | |||
| import shutil | |||
| import nib | |||
| import nibabel as nib | |||
There was a problem hiding this comment.
that will probably fail if the library is not installed yet. You probably want to move these imports after the call to check_and_install_python_packages()
1 task
|
@laurentletg I created a branch with suggestions here: #43 Feel free to incorporate them. I'm also happy to take on this PR. |
|
I'm closing this PR as it has been superseded by #43 (which has just been merged) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated PR.
Note I closed my previous PR since there were unnecessary lines added to my previous commit.