Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvode and condition_order args #30

Merged
merged 4 commits into from
Jan 6, 2025
Merged

cvode and condition_order args #30

merged 4 commits into from
Jan 6, 2025

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Jan 5, 2025

Some args for cvode performance testing.

  • -method N 0-fixed, 1-global cvode, 2-local cvode
  • -2nd_order_thresh 2nd order correct threshold detection (cvode only)

@nrnhines nrnhines requested a review from JCGoran January 6, 2025 00:08
@nrnhines
Copy link
Member Author

nrnhines commented Jan 6, 2025

Since pre 9.0 NEURON versions with CoreNEURON commented out the hh.mod TABLE statement and the spike train standard for comparison is now with the TABLE statement, 602f5ca skips the test unless the NEURON major version is >= 9

Copy link

@JCGoran JCGoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ringtest.py Outdated Show resolved Hide resolved
ringtest.py Outdated Show resolved Hide resolved
@nrnhines nrnhines merged commit b096d53 into master Jan 6, 2025
2 checks passed
@nrnhines nrnhines deleted the hines/cvargs branch January 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants