Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude failing model from running in CI #101

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jan 22, 2024

The model https://github.com/ModelDBRepository/144538 is failing in the CI using NEURON 9 with the following error:

%neuron-executable%: syntax error
 in arm.hoc near line 163
       nqDP.append(1,xo.id,DP,xo.zloc,MTYP.o(xo.zloc).s,shminmlen,shmaxmlen)
                                          ^
        xopen("arm.hoc")
      execute1("{xopen("ar...")
    load_file("arm.hoc")
%neuron-executable%: hoc_Load_file arm.hoc
 in arm.hoc near line 33
 ^
        load_file("arm.hoc")
hoc_run1: caught exception: hoc_execerror: hoc_Load_file arm.hoc

It's not really clear what the source of the problem is, and as the model is quite old, it's probably better to fix it later, but exclude it from the CI in the meantime.

@JCGoran JCGoran mentioned this pull request Jan 22, 2024
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nrnhines @ramcdougal : FYI. We are excluding this model temporarily. Maybe this error / fix might be obvious to you?

@pramodk pramodk merged commit 07d9207 into master Jan 22, 2024
1 check passed
@pramodk pramodk deleted the jelic/exclude_old_model branch January 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants