New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings about dynamic units #100

Merged

JCGoran merged 1 commit into master from jelic/curate_patterns

Jan 22, 2024

Collaborator

JCGoran commented Jan 22, 2024

In NEURON 8.2.3, there are warnings of the form:

%neuron-executable%: Assignment to modern physical constant FARADAY
 in batch_.hoc near line 90
 FARADAY = 96520.        /* Hoc default = 96484.56 */
                                                     ^

which do not appear to be present in NEURON 9. Warnings of this kind are present in the following models:

105507
106891
116838
116862
12631
136095
136310
138379
144538
145672

Note that model 144538 has some additional issues which should be resolved (see this run).


          Remove warnings about dynamic units

aea951a

pramodk approved these changes

View reviewed changes

Member

pramodk left a comment

LGTM

JCGoran merged commit 3e69e7b into master

1 of 2 checks passed

JCGoran mentioned this pull request

Remove warnings about dynamic units in additional models #105

Merged

JCGoran deleted the jelic/curate_patterns branch

March 10, 2024 06:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet