Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CentOS 7 and pin NumPy version #70

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Remove CentOS 7 and pin NumPy version #70

merged 4 commits into from
Jul 24, 2024

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Jul 23, 2024 •
edited
Loading

CentOS 7 reached EOL on June 30th, 2024. Also pin NumPy because NMODL tries to upgrade it.

EDIT: pinning makes no difference for 8.2.5 since it stubbornly tries to install NumPy 2 later, which is why we need to ship 8.2.6.

pramodk
pramodk reviewed Jul 23, 2024
View reviewed changes
Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JCGoran : Is CentOS 7 causing trouble in CI or it's still working OK?

The reason we have kept this is that we have our own users on CentOS/RH7. BB5 is still RH7! :)

@JCGoran
Copy link
Collaborator Author

JCGoran commented Jul 23, 2024

@pramodk it's causing problems in the build CI: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/10055747236/job/27793876304

@JCGoran JCGoran changed the title Remove CentOS 7 Remove CentOS 7 and pin NumPy version Jul 23, 2024
matz-e
matz-e reviewed Jul 23, 2024
View reviewed changes
Copy link

@matz-e matz-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme should be changed, too.

@JCGoran JCGoran merged commit ec90808 into main Jul 24, 2024
12 of 21 checks passed
@JCGoran JCGoran deleted the jelic/remove_centos7 branch July 24, 2024 07:55
This was referenced Jul 24, 2024
Closed
Closed
@JCGoran JCGoran linked an issue Jul 24, 2024 that may be closed by this pull request
Migrate away from CentOS 7 #68
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk left review comments

@matz-e matz-e matz-e approved these changes

@heerener heerener heerener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate away from CentOS 7
4 participants
@JCGoran @pramodk @matz-e @heerener