Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rootURL assignment in main.js #43

Merged
merged 2 commits into from
May 22, 2024

Conversation

hanayik
Copy link
Contributor

@hanayik hanayik commented May 22, 2024

This PR fixes a bug that was introduced in my previous PR #42.

In PR #42, I added the ability to use query parameters to immediately run a model by setting the model query string. As an example, the URL https://brainchop.org/?model=11 would immediately set the model to the model at the 11th index in the list and then run it. This behaviour is useful for testing in an automated way. This method didn't work when deployed to github pages.

This should be fixed now.

@Mmasoud1 Mmasoud1 merged commit 098688a into neuroneural:master May 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants