Ignore readline errors #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the includeantruntime property on the javac Ant task is not included it causes warnings to be emitted in the build. Moreover, the recommendation in the Ant manual has for many years been to set it to false. See: http://ant.apache.org/manual/index.html
certain platforms. This commit should essentially fix the issue. The error in question is: Exception in thread "main" java.io.UnsupportedEncodingException: at org.gnu.readline.Readline.addToHistoryImpl(Native Method) at org.gnu.readline.Readline.addToHistory(Readline.java:259) at henplus.HenPlus.storeLineInHistory(HenPlus.java:342) at henplus.HenPlus.run(HenPlus.java:464) at henplus.HenPlus.main(HenPlus.java:679)
| // but due to it being thrown from the native code, it's not | ||
| // declared properly on the java interface so we can't | ||
| // specifically catch it here. | ||
| } |
There was a problem hiding this comment.
Could the caught exception be runtime-tested to be an UnsupportedEncoding exception in order to make sure not to swallow anything else?
There was a problem hiding this comment.
Probably. Haven't checked. The issue is, that the exception is thrown from the native code, so a bit of unwrapping magic would need to be done. I'll fix and recommit.
|
Any update on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is just a quick fix that for an issue I've encountered using HenPlus under Docker + AlpineLinux (https://hub.docker.com/r/boky/henplus/).
Basically if the output includes any no-US ASCII charcters java readline liberary chokes and this fix ignores the error, which is not really important in the end.