fix hsic kernel bug (#85)

* fix hsic kernel bug * release v0.1.2
neurodata · May 6, 2020 · 7cd3382 · 7cd3382
1 parent 185ddac
commit 7cd3382
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 9 deletions.
diff --git a/docs/news.rst b/docs/news.rst
@@ -3,14 +3,20 @@
 Release Log
 ===========
 
-v0.1.0
+v0.1.2
 ------
-| **Release date:** 25 February 2020
-| **Supports:** Python 3.5+.
-| :doc:`release/0.1.0-release`.
+| **Release date:** 5 May 2020
+| **Supports:** Python 3.6+.
+| :doc:`release/0.1.2-release`.
 
-v0.1.0
+v0.1.1
 ------
 | **Release date:** 28 April 2020
 | **Supports:** Python 3.6+.
 | :doc:`release/0.1.1-release`.
+
+v0.1.0
+------
+| **Release date:** 25 February 2020
+| **Supports:** Python 3.5+.
+| :doc:`release/0.1.0-release`.
diff --git a/docs/release/0.1.2-release.rst b/docs/release/0.1.2-release.rst
@@ -0,0 +1,25 @@
+hyppo v0.1.2 Release Notes
+==========================
+
+.. contents::
+
+hyppo 0.1.2 does not include any new features, just fixes. This release requires
+Python 3.6+.
+
+Fixes
+-----
+
+*k*-sample testing
+^^^^^^^^^^^^^^^^^^
+Fixed MMD/k-samp;e Hsic not running bug.
+
+Authors
+=======
+
+This release contains work by the following people (contributed at least
+one patch to this release, names in alphabetical order by last name):
+
+* Sambit Panda
+
+A total of 1 person contributed to this release.
+People with a "+" by their names contributed a patch for the first time.
diff --git a/hyppo/ksample/ksamp.py b/hyppo/ksample/ksamp.py
@@ -74,13 +74,12 @@ def __init__(self, indep_test, compute_distance=euclidean, bias=False):
         }
         if indep_test not in test_names.keys():
             raise ValueError("Test is not a valid independence test")
-        if indep_test == "Hsic" and compute_distance == euclidean:
+        if indep_test == "hsic" and compute_distance == euclidean:
             compute_distance = gaussian
+        self.indep_test_name = indep_test
         indep_test = test_names[indep_test]
-        self.indep_test_name = indep_test.__name__
 
-        dist_tests = [Dcorr, HHG, Hsic, MGC]
-        if indep_test in dist_tests:
+        if self.indep_test_name in ["dcorr", "hhg", "hsic", "mgc"]:
             if self.indep_test_name == "hsic":
                 self.indep_test = indep_test(compute_kernel=compute_distance, bias=bias)
             elif self.indep_test_name == "dcorr":