Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Fix badge link formatting in README.md #137

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 23, 2024

Changes proposed in this pull request:

  • Fixes unwanted blue underlines between badges in the README, which suggest that some of the whitespace is being interpreted as part of the link
  • Removing the newlines before </a> seems to fix the issue (note: using markdown syntax also works!)

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Oct 23, 2024
Copy link

netlify bot commented Oct 23, 2024

Deploy Preview for upload-ui ready!

Name Link
🔨 Latest commit 88714dc
🔍 Latest deploy log https://app.netlify.com/sites/upload-ui/deploys/67185f8e44a8bd0008b6c244
😎 Deploy Preview https://deploy-preview-137--upload-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai alyssadai self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (5397e4d) to head (88714dc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   56.66%   56.66%           
=======================================
  Files          18       18           
  Lines         210      210           
  Branches       50       50           
=======================================
  Hits          119      119           
  Misses         91       91           
Flag Coverage Δ
tests 56.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alyssadai alyssadai changed the title [MNT] Fix badge links in README.md [MNT] Fix badge link formatting in README.md Oct 23, 2024
@alyssadai alyssadai added skip-release PR doesn't appear in the changelog and preserves current version when merged and removed pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) labels Oct 23, 2024
@rmanaem rmanaem self-requested a review October 23, 2024 15:13
Copy link
Collaborator

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit b4a1600 into main Oct 23, 2024
16 checks passed
@alyssadai alyssadai deleted the alyssadai-patch-1 branch October 23, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants