Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Removed .env volume from graph service #90

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[MNT] Removed .env volume from graph service #90

merged 4 commits into from
Oct 23, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 23, 2024 •
edited by alyssadai
Loading

Changes proposed in this pull request:

  • Removed source command invocation for reading .env file in graphdb_setup.sh
  • Removed .env volume and NB_GRAPH_ADDRESS from graph service

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) label Oct 23, 2024
alyssadai
alyssadai approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

One 🍒: I'd recommend removing the --env-file-path flag when graphdb_setup.sh is called:

recipes/scripts/setup.sh

Line 47 in 7b86695

./graphdb_setup.sh --env-file-path /usr/src/neurobagel/.env "${NB_GRAPH_ADMIN_PASSWORD}"

to avoid confusion for ourselves

@rmanaem rmanaem merged commit 04b6631 into main Oct 23, 2024
@rmanaem rmanaem deleted the maint-87 branch October 23, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revisit if .env needs to be mounted into the container
2 participants
@rmanaem @alyssadai