Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Remove container-internal ports and unneeded graph config vars #80

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Aug 16, 2024

Changes proposed in this pull request:

  • The following variables have been removed as .env-configurable options and now have hardcoded values in docker-compose.yml:
    1. NB_GRAPH_ADDRESS
    2. NB_GRAPH_PORT *
    3. NB_GRAPH_IMG
    4. NB_NAPI_PORT *
    5. NB_FAPI_PORT *

(*) Note that the container environment variables corresponding to these options still exist and are still expected/used by scripts within the Compose stack, their port values are just now hardcoded in the container environment

  • e.g., setup.sh for the graph looks for the value of an NB_GRAPH_PORT env var; the n-API will use NB_API_PORT from the container environment to determine what port to launch uvicorn on

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Aug 16, 2024
@surchs surchs self-requested a review August 16, 2024 18:43
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
🧑‍🍳

@alyssadai alyssadai merged commit 2a27db2 into main Aug 16, 2024
2 checks passed
@alyssadai alyssadai deleted the reduce-env-vars branch August 16, 2024 18:58
Copy link

🚀 PR was released in v0.2.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the number of configurable options / environment variables to declutter or at least restructure
2 participants