-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Implemented UI improvements #16
Conversation
✅ Deploy Preview for neurobagel-query ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive amount of work @rmanaem! Thanks a lot for that 🎉 - and sorry for the long wait for the review. Everything looks very nice, and does what it is supposed to - we'll get to the bottom of the performance issues in a future PR.
That said, I have two main things I would address:
- stateful error handling in the QueryForm component. I think we should not keep state there and instead just compute errors based on props directly (you're doing that for some, but not all errors). See comments
- Snackbar: I think this is a beautiful piece of code and quite a complex achievement. But as I commented inline in the App, there is an existing solution for it and by not using that we now have to maintain a complex piece of code. So I'd say: let's adopt the third party solution instead.
Let me know if you'd like me to push these changes direct to the branch. I understand that we'll have to likely fix #19 then - happy to help with that too.
Some minor comments throughout the PR, take a look
--------- Co-authored-by: rmanaem <[email protected]>
also learn a bit about promises
- learn more about async / await
… `async` function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice 🎉 ! Thanks @rmanaem.
One refactor suggestion, then 🧑🍳
🚀 PR was released in |
Checklist
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see https://neurobagel.org/contributing/pull_requests for more info)Closes #XXXX
For new features:
For bug fixes: