Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Ensure np namespace URL has trailing / #35

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 3, 2024

Changes proposed in this pull request:

  • Previously, since the np namespace URL did not have a trailing slash, pipeline name terms were appearing formatted in the graph as e.g.,: https://github.com/nipoppy/pipeline-catalog/tree/main/processingfmriprep, which is not ideal (interestingly, json-ld playground isn't even able to expand the term URI when the prefix URL lacks a trailing separator, it just stays as np:fmriprep)
  • This PR regenerates the example JSONLD files to ensure the np URL ends with a /

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai requested a review from rmanaem October 3, 2024 17:36
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit d44875e into main Oct 3, 2024
@alyssadai alyssadai deleted the update-np-url branch October 3, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants