Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Capitalized age heuristics #13

Merged
merged 1 commit into from
Oct 3, 2023
Merged

[MNT] Capitalized age heuristics #13

merged 1 commit into from
Oct 3, 2023

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 3, 2023 •
edited by alyssadai
Loading

Closes #12

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem changed the title Capitalized age heuristics [MNT] Capitalized age heuristics Oct 3, 2023
@alyssadai alyssadai self-requested a review October 3, 2023 16:11
alyssadai
alyssadai approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

🍒 : I think this could also fit under the [MODEL] prefix since the vocabulary changes will take effect across the board. Will let you pick 🙂

@rmanaem rmanaem merged commit d8738d9 into main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssadai alyssadai alyssadai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Capitalize age heuristics
2 participants
@rmanaem @alyssadai