Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNT] Update JSON and JSONLD files to use new NCIT namespace #10

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[MNT] Update JSON and JSONLD files to use new NCIT namespace #10

merged 1 commit into from
Sep 20, 2023

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 20, 2023 •
edited by surchs
Loading

Closes #9

This PR is related to neurobagel/bagel-cli#139

Changes proposed in this pull request:

  • JSONLD files regenerated using new NCIT namespace prefix for healthy controls

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai mentioned this pull request Sep 20, 2023
Closed
6 tasks
@surchs surchs self-requested a review September 20, 2023 14:26
surchs
surchs approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 🎉

🧑‍🍳

@alyssadai alyssadai merged commit 63dc797 into main Sep 20, 2023
@rmanaem rmanaem deleted the fix-9/add-ncit-prefix branch September 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update example files with new healthy control term prefix and context
2 participants
@alyssadai @surchs