Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Handle empty local nodes file #67

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jan 31, 2024

Changes proposed in this pull request:

  • Empty local_nb_nodes.json file now handled gracefully without erroring
  • Added new test case for above
  • Moved test case for local nodes file with empty dict {} to more appropriate test (as it currently raises a warning)

Checklist

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see https://neurobagel.org/contributing/pull_requests for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Jan 31, 2024
@alyssadai alyssadai marked this pull request as ready for review January 31, 2024 17:06
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7729709162

  • 0 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 99.322%

Totals Coverage Status
Change from base Build 7722223666: 0.005%
Covered Lines: 586
Relevant Lines: 590

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very nice! 🧑‍🍳

@alyssadai alyssadai merged commit 9d685db into main Feb 1, 2024
5 checks passed
@alyssadai alyssadai deleted the handle-empty-nodes-file branch February 1, 2024 18:44
@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

🚀 PR was released in v0.1.0 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case for empty local_nb_nodes.json file
3 participants