Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add new query param for nodes that defaults to a prepopulated index #30
[ENH] Add new query param for nodes that defaults to a prepopulated index #30
Changes from 26 commits
73d57d7
3f56fa6
ca2c113
d621bee
0b5277c
40627d6
945a3ef
a0b4777
02d2ba7
98343a8
0b5e6d4
cff42cb
6d81496
2a801a9
3a6451d
84f98a2
763ff30
b4e6b75
292752c
e11c0f7
302657c
2171604
3cbe7dc
92e7d95
6dd2df9
f8b366a
d6e8112
40daf15
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean that the
get_terms
request will always go out to all known nodes, regardless of any subselection the user might have made? in other words, wouldn't we also want to restrict this byas above in
async def get
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened a separate issue for this
/{data_element_URI}
request based on specified nodes #36as I think this could benefit from some further discussion.
Right now, I think only the query tool uses this endpoint (
/attributes/{data_element_URI}
) to get all the instances of a given controlled term likenb:Assessment
(across the known graphs) to populate the dropdown options for the UI. I imagine this would be separate from/before the user actually selects specific nodes in the app to send a query to - not sure if we want the query tool to have dynamically changing dropdown options as a result.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isort? mind opening an issue to add this to the CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isort is already included in the precommit hooks for this repo! 🙂
federation-api/.pre-commit-config.yaml
Lines 25 to 29 in f85c44b
I think this is the expected import order following