Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add route for fetching available versions of a pipeline across n-APIs #125

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 17, 2024

Changes proposed in this pull request:

  • Added new router /pipelines with a /{pipeline_term}/versions subpath that sends a federated request to all n-APIs for available versions of the specified pipeline
  • Removed extraneous query params (currently ignored by the n-API) in the URL used to send requests to the current /attributes endpoint of n-APIs

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) label Oct 17, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11392244268

Details

  • 37 of 40 (92.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 96.708%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/api/routers/pipelines.py 10 11 90.91%
app/api/crud.py 10 12 83.33%
Totals Coverage Status
Change from base Build 11350110286: -0.3%
Covered Lines: 617
Relevant Lines: 638

💛 - Coveralls

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alyssadai, looks very nice and clean

🧑‍🍳

@alyssadai alyssadai merged commit 1c879d7 into main Oct 18, 2024
6 of 7 checks passed
@alyssadai alyssadai deleted the add-pipelines-router branch October 18, 2024 16:23
Copy link

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new endpoint to return pipeline vers. for specific pipeline name for query tool
3 participants