Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Implemented pipeline_name and pipeline_version query params #121

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[ENH] Implemented pipeline_name and pipeline_version query params #121

merged 1 commit into from
Oct 15, 2024

Conversation

rmanaem
Copy link
Contributor

@rmanaem rmanaem commented Oct 11, 2024 •
edited by surchs
Loading

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) label Oct 11, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11298974957

Details

  • 5 of 7 (71.43%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 97.0%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/api/crud.py 2 4 50.0%
Totals Coverage Status
Change from base Build 11227812834: -0.3%
Covered Lines: 582
Relevant Lines: 600
💛 - Coveralls

@surchs surchs self-requested a review October 15, 2024 14:59
surchs
surchs approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rmanaem, looks good to me. I guess there isn't much to test atm directly here, we'd need to look at e2e tests.

🧑‍🍳

app/api/crud.py Show resolved Hide resolved
app/api/crud.py Show resolved Hide resolved
@rmanaem rmanaem merged commit eacdaa7 into main Oct 15, 2024
6 of 7 checks passed
@rmanaem rmanaem deleted the feat-113 branch October 15, 2024 16:13
@neurobagel-bot Neurobagel Bot
Copy link

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

Assignees
No one assigned
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow querying for pipeline name and version
3 participants
@rmanaem @coveralls @surchs