Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Disable redirect slashes and remove trailing slashes from routes #109

Merged
merged 8 commits into from
Aug 2, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Jul 31, 2024

Changes proposed in this pull request:

  • FastAPI version update to allow disabling redirect_slashes globally (available since https://github.com/fastapi/fastapi/releases/tag/0.98.0)
  • API will no longer redirect requests with or without a trailing slash to the version defined in the route decorator
  • /query, /nodes routes no longer expect a slash at the end (or before query params)
  • Minor fix of test context for tests requiring auth to be enabled
  • uvicorn command in Dockerfile updated to trust X-Forwarded... proxy headers from all remote IPs, to ensure we don't lose https from a request once behind a proxy

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) labels Jul 31, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 31, 2024

Pull Request Test Coverage Report for Build 10185691715

Details

  • 35 of 35 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 97.302%

Totals Coverage Status
Change from base Build 10151517131: 0.3%
Covered Lines: 577
Relevant Lines: 593

💛 - Coveralls

@alyssadai alyssadai marked this pull request as ready for review July 31, 2024 15:13
@alyssadai alyssadai requested a review from rmanaem July 31, 2024 15:13
@alyssadai
Copy link
Contributor Author

@rmanaem, once you've reviewed this, mind updating neurobagel/query-tool#235 accordingly?

@rmanaem
Copy link
Contributor

rmanaem commented Jul 31, 2024

@rmanaem, once you've reviewed this, mind updating neurobagel/query-tool#235 accordingly?

Yea, will do

Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 188acc1 into main Aug 2, 2024
5 checks passed
@alyssadai alyssadai deleted the disable-redirect-slashes branch August 2, 2024 16:00
Copy link

neurobagel-bot bot commented Aug 2, 2024

🚀 PR was released in v0.3.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor-breaking Feature or enhancement that breaks compatibility, will increment minor version (0.+1.0) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routes without trailing slash cause 307 redirect
3 participants