Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Combine Stardog and graphDB setup instructions #92

Merged
merged 9 commits into from
Sep 26, 2023
Merged

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Sep 22, 2023

Closes #74
Closes neurobagel/api#119
Closes #93

Changes proposed in this pull request:

  • Added Linked tabs to group instructions for graphDB and Stardog separately across the page
  • changed all references to generic database user to DBUSER (and example password to DBPASSWORD) -> maybe we should not keep the password the same to discourage people from actually sticking with it 🤔
  • Small typo fix for data upload script example, discovered by @alyssadai

Checklist

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit 23f1cb7
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/6512f2357f5f380008e6120b
😎 Deploy Preview https://deploy-preview-92--neurobagel-documentation.netlify.app/infrastructure
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs marked this pull request as ready for review September 25, 2023 20:11
@rmanaem rmanaem self-requested a review September 25, 2023 20:14
Copy link
Contributor

@rmanaem rmanaem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @surchs. I left one comment, see if it should be addressed other than that good to go! 🧑‍🍳

docs/infrastructure.md Outdated Show resolved Hide resolved
and show it with a nicer figure
@surchs surchs merged commit f14d94d into main Sep 26, 2023
@surchs surchs deleted the surchs/issue74 branch September 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants