Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Update instructions for changing passwords and the default deployment profile #228

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 25, 2024

Changes proposed in this pull request:

  • Default profile changed to full_stack
  • Added instructions for using COMPOSE_PROFILES var in .env
  • Updated instructions for changing admin/user passwords using .txt files

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit c9075ca
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/66f4c5612538380008f12ab6
😎 Deploy Preview https://deploy-preview-228--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@surchs surchs self-requested a review September 25, 2024 21:46
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alyssadai. Thanks for all the nice changes!

I disagree with the "here's how you change the default profile" bit. Let's not add that. More generally: let's not just tack a change like that onto an unrelated PR so we have a chance to first discuss it in an issue in the future.

Otherwise all good.

docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/getting_started.md Outdated Show resolved Hide resolved
docs/maintaining.md Show resolved Hide resolved
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@alyssadai alyssadai merged commit 7a534e4 into main Sep 27, 2024
6 checks passed
@alyssadai alyssadai deleted the adai/update-docs branch September 27, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

2 participants