Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add Discord link and mention semver label in latest images #223

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 10, 2024

Changes proposed in this pull request:

  • Slight restructuring of "Getting Help" page based on type of question
  • Explain how to find semver for a latest Neurobagel image
  • Remove outdated note about needing to manually update data in the graph before restarting services (happens automatically as of [FIX] Enable graph setup to run on stack restart recipes#57)

Checklist

Please leave checkboxes empty for PR reviewers

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF]) see our Contributing Guidelines for more info)
  • PR links to GitHub issue with mention Closes #XXXX
  • Checks pass

@alyssadai alyssadai changed the title Add Discord link and mention semver label in latest images [ENH] Add Discord link and mention semver label in latest images Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for neurobagel-documentation ready!

Name Link
🔨 Latest commit f63a3b4
🔍 Latest deploy log https://app.netlify.com/sites/neurobagel-documentation/deploys/66e1f2dc87261800080df880
😎 Deploy Preview https://deploy-preview-223--neurobagel-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alyssadai
Copy link
Contributor Author

alyssadai commented Sep 10, 2024

The markdown-link-check is failing due to several nipoppy links being out of date, which I think is a result of the nipoppy code repo refactoring that has happened.

Not sure if it makes sense to recruit the Nipoppy team to fix these as the Nipoppy section will be removed from our docs soon (see #218) ... should we add a temporary rule to ignore these links for now?

Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some suggestions -> 🧑‍🍳

docs/getting_help.md Outdated Show resolved Hide resolved
docs/getting_help.md Outdated Show resolved Hide resolved
docs/getting_help.md Outdated Show resolved Hide resolved
docs/getting_help.md Outdated Show resolved Hide resolved
docs/getting_help.md Outdated Show resolved Hide resolved
docs/maintaining.md Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit 3595320 into main Sep 11, 2024
6 checks passed
@alyssadai alyssadai deleted the update-docs branch September 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to Neurobagel Discord server
2 participants