Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Resolve session path for subjects with single session #169

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

surchs
Copy link
Contributor

@surchs surchs commented Jun 17, 2023

Closes #168

@github-actions
Copy link

Pull Request Test Coverage Report for Build 5296115180

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.177%

Totals Coverage Status
Change from base Build 5286878156: 0.0%
Covered Lines: 482
Relevant Lines: 486

💛 - Coveralls

1 similar comment
@github-actions
Copy link

Pull Request Test Coverage Report for Build 5296115180

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.177%

Totals Coverage Status
Change from base Build 5286878156: 0.0%
Covered Lines: 482
Relevant Lines: 486

💛 - Coveralls

@alyssadai alyssadai self-requested a review June 19, 2023 15:16
Copy link
Contributor

@alyssadai alyssadai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @surchs!

I think we can now actually switch to purely using layout.root to fetch the bids directory path in this util function (get_session_path), which may simplify the function definition/call further. Opened a refactoring iss for this, #171.

@alyssadai
Copy link
Contributor

Given unavailability of PR assignee this week, will merge on their behalf.

@alyssadai alyssadai merged commit 86eb634 into main Jun 19, 2023
@alyssadai alyssadai deleted the surchs/issue168 branch June 19, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BIDS session path not resolved when subject has only one session
2 participants