-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Split generic /attributes
endpoints into attribute-specific routers
#358
Conversation
Pull Request Test Coverage Report for Build 11388736781Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alyssadai, very cool PR.
Couple of clarification comments, but otherwise 🧑🍳
🚀 PR was released in |
/attributes
router into attribute-specific routers #354Changes proposed in this pull request:
GET /attributes/{data_element_uri}
andGET /attributes/{data_element_uri}/vocab
endpoints removed/assessments
/diagnoses
/
(i.e., get all instances in the graph) and/vocab
subpaths of attribute-specific routerstest_attribute_factory_routes.py
Checklist
This section is for the PR reviewer
[ENH]
,[FIX]
,[REF]
,[TST]
,[CI]
,[MNT]
,[INF]
,[MODEL]
,[DOC]
) (see our Contributing Guidelines for more info)skip-release
(to be applied by maintainers only)Closes #XXXX
For new features:
For bug fixes: