Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed a typo in filtering pipeline name #351

Merged
merged 1 commit into from
Oct 15, 2024
Merged

[FIX] Fixed a typo in filtering pipeline name #351

merged 1 commit into from
Oct 15, 2024

Conversation

rmanaem
Copy link
Collaborator

@rmanaem rmanaem commented Oct 11, 2024

Changes proposed in this pull request:

  • Fixed a typo (() in the create_query function when filtering pipeline name which lead to a syntax error when querying for a specific pipeline name

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@rmanaem rmanaem added the pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) label Oct 11, 2024
@rmanaem rmanaem changed the title [MNT] Fixed a typo in filtering pipeline name [FIX] Fixed a typo in filtering pipeline name Oct 11, 2024
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11298825515

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.507%

Totals Coverage Status
Change from base Build 11277385309: 0.0%
Covered Lines: 744
Relevant Lines: 779

💛 - Coveralls

@surchs surchs self-requested a review October 15, 2024 14:54
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @rmanaem !

🧑‍🍳

@rmanaem rmanaem merged commit 1313601 into main Oct 15, 2024
10 checks passed
@rmanaem rmanaem deleted the small-patch branch October 15, 2024 15:07
Copy link

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
Status: Review - Done
Development

Successfully merging this pull request may close these issues.

3 participants