Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add /pipelines router & route for fetching available pipeline versions #350

Merged
merged 7 commits into from
Oct 16, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Oct 11, 2024

Changes proposed in this pull request:

  • Added new router /pipelines with a /{pipeline_term}/versions subpath that returns available versions of a specific pipeline resource
  • Renamed existing util for unpacking a response from the graph, for clarity

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) and removed release Create a release when this PR is merged labels Oct 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Oct 11, 2024

Pull Request Test Coverage Report for Build 11357952549

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 28 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 95.641%

Totals Coverage Status
Change from base Build 11277385309: 0.1%
Covered Lines: 768
Relevant Lines: 803

💛 - Coveralls

@alyssadai alyssadai changed the title [ENH] Add new path to /attributes for fetching available pipeline versions [ENH] Add /pipelines router & route for fetching available pipeline versions Oct 11, 2024
@alyssadai alyssadai marked this pull request as ready for review October 15, 2024 05:34
@rmanaem rmanaem requested a review from surchs October 15, 2024 17:04
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alyssadai

left two comments, 🧑‍🍳

tests/test_pipelines.py Outdated Show resolved Hide resolved
tests/test_pipelines.py Outdated Show resolved Hide resolved
@alyssadai alyssadai merged commit 30d447f into main Oct 16, 2024
8 checks passed
@alyssadai alyssadai deleted the update-attributes-route branch October 16, 2024 03:18
Copy link

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-minor Non-breaking feature or enhancement, will increment minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new endpoint to return pipeline vers. for specific pipeline name for query tool
3 participants