Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Update README links and simplify Docker Compose instructions #340

Merged
merged 3 commits into from
Sep 11, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Sep 10, 2024

Changes proposed in this pull request:

  • Several outdated links fixed
  • Instructions for installing API via Docker Compose mostly removed in favour of a link to our official "Getting Started" docs
  • Added GH wf for Linkspector (newer tool w/ more features created by markdown-link-check dev) for checking for broken markdown links in the README.md

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@surchs surchs self-requested a review September 10, 2024 22:21
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🧑‍🍳

Do we have some way of knowing if we have broken links in our README markdown files? Probably not, huh?

@alyssadai
Copy link
Contributor Author

alyssadai commented Sep 11, 2024

Do we have some way of knowing if we have broken links in our README markdown files?

good idea, I added markdown-link-check to the pre-commit config! should work the same as in our docs repo.

edit: switched to using new & improved (?) linkspector action by the creator of markdown-link-check, since the latter does not have options to exclude files (i.e.., non-README md files in this case)

- newer, more configuration options including file exclusion
@alyssadai alyssadai merged commit efe6f91 into main Sep 11, 2024
8 checks passed
@alyssadai alyssadai deleted the fix-readme branch September 11, 2024 19:17
Copy link

🚀 PR was released in v0.4.0 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link to environment variable docs in README
2 participants