Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix reference for DOCKERHUB_REPO in build_docker_on_release.yml #337

Merged
merged 1 commit into from
Aug 13, 2024
Merged

[CI] Fix reference for DOCKERHUB_REPO in build_docker_on_release.yml #337

merged 1 commit into from
Aug 13, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Aug 13, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Variables defined for GH Actions should be accessed through the vars context, not the env context !
  • This PR will be used to trigger a release

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) labels Aug 13, 2024
@alyssadai alyssadai changed the title [CI] Fix reference for DOCKERHUB_REPO (again) in build_docker_on_release.yml [CI] Fix reference for DOCKERHUB_REPO in build_docker_on_release.yml Aug 13, 2024
@alyssadai alyssadai merged commit 8f128ba into main Aug 13, 2024
8 checks passed
@alyssadai alyssadai deleted the alyssadai-patch-1 branch August 13, 2024 20:48
@neurobagel-bot Neurobagel Bot
Copy link

🚀 PR was released in v0.3.1 🚀

@neurobagel-bot neurobagel-bot bot added the released This issue/pull request has been released. label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr-internal Non-user-facing code improvement, will increment patch version when merged (0.0.+1) release Create a release when this PR is merged released This issue/pull request has been released.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alyssadai