Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Disable timeout for request to graph #305

Merged
merged 1 commit into from
Apr 13, 2024
Merged

[FIX] Disable timeout for request to graph #305

merged 1 commit into from
Apr 13, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 12, 2024 •
edited by surchs
Loading

Changes proposed in this pull request:

  • Default httpx request timeout disabled

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added release Create a release when this PR is merged pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) labels Apr 12, 2024
@rmanaem rmanaem self-requested a review April 12, 2024 16:50
@surchs surchs self-requested a review April 12, 2024 23:48
surchs
surchs approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alyssadai. Looks good 🧑‍🍳

I'd say we don't need a regression test here - despite the bug label.

@alyssadai alyssadai removed the release Create a release when this PR is merged label Apr 13, 2024
@alyssadai
Copy link
Contributor Author

Removing release label for now as I'd prefer to do another coordinated patch release with the query tool following the latest bug fixes.

@alyssadai alyssadai merged commit 1e9ef34 into main Apr 13, 2024
7 checks passed
@alyssadai alyssadai deleted the disable-httpx-timeout branch April 13, 2024 03:33
@surchs
Copy link
Contributor

surchs commented Apr 16, 2024

🚀 PR was released in v0.2.1 🚀

@surchs surchs added the released This issue/pull request has been released. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surchs surchs surchs approved these changes

@rmanaem rmanaem Awaiting requested review from rmanaem

Assignees
No one assigned
Labels
pr-bug-fix Bug fix, will increment patch version when merged (0.0.+1) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default httpx timeout too short
2 participants
@alyssadai @surchs