Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Delete leftover .template-env and docker-compose.yml #298

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

alyssadai
Copy link
Contributor

@alyssadai alyssadai commented Apr 11, 2024

Changes proposed in this pull request:

  • .template-env and docker-compose.yml in this repo superseded by neurobagel/recipes repo

Checklist

This section is for the PR reviewer

  • PR has an interpretable title with a prefix ([ENH], [FIX], [REF], [TST], [CI], [MNT], [INF], [MODEL], [DOC]) (see our Contributing Guidelines for more info)
  • PR has a label for the release changelog or skip-release (to be applied by maintainers only)
  • PR links to GitHub issue with mention Closes #XXXX
  • Tests pass
  • Checks pass

For new features:

  • Tests have been added

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

@alyssadai alyssadai added the skip-release PR doesn't appear in the changelog and preserves current version when merged label Apr 11, 2024
@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2024

Pull Request Test Coverage Report for Build 8692311250

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.1%) to 99.788%

Totals Coverage Status
Change from base Build 8620593363: 4.1%
Covered Lines: 940
Relevant Lines: 942

💛 - Coveralls

@surchs surchs self-requested a review April 11, 2024 15:53
Copy link
Contributor

@surchs surchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧑‍🍳

@surchs
Copy link
Contributor

surchs commented Apr 11, 2024

@alyssadai please also remove / update the link here: https://github.com/neurobagel/api?tab=readme-ov-file#set-the-environment-variables

@alyssadai alyssadai changed the title [FIX] Delete leftover .template-env [FIX] Delete leftover .template-env and docker-compose.yml Apr 15, 2024
@alyssadai alyssadai merged commit 0621e0a into main Apr 15, 2024
6 checks passed
@alyssadai alyssadai deleted the alyssadai-patch-1 branch April 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-release PR doesn't appear in the changelog and preserves current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove leftover .template-env file
3 participants