Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more fields to resource pools #2202

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

zubenkoivan
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the review-ready PR is ready for the review label Feb 1, 2025
Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (3171c19) to head (b4c0083).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
platform_api/api.py 0.00% 4 Missing ⚠️
platform_api/orchestrator/kube_orchestrator.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2202      +/-   ##
==========================================
+ Coverage   68.79%   68.81%   +0.02%     
==========================================
  Files          39       39              
  Lines        7063     7068       +5     
  Branches      842      842              
==========================================
+ Hits         4859     4864       +5     
  Misses       2074     2074              
  Partials      130      130              
Flag Coverage Δ
unit 68.81% <57.14%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
platform_api/cluster_config_factory.py 92.20% <ø> (ø)
platform_api/orchestrator/job_request.py 90.58% <100.00%> (+0.05%) ⬆️
platform_api/resource.py 98.50% <100.00%> (+0.06%) ⬆️
platform_api/orchestrator/kube_orchestrator.py 32.90% <0.00%> (ø)
platform_api/api.py 24.19% <0.00%> (ø)

@zubenkoivan zubenkoivan merged commit f0b82f9 into master Feb 1, 2025
10 of 13 checks passed
@zubenkoivan zubenkoivan deleted the iz/add-more-fields-to-resource-pools branch February 1, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready PR is ready for the review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant