Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Add docker workflow to nm nightly/release and fixed some minor bugs in wheel uploading #334

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Add docker workflow to nm nightly/release and fixed some minor bugs in wheel uploading #334

merged 5 commits into from
Jun 25, 2024

Conversation

dhuangnm
Copy link
Member

  1. Added/updated publish docker workflow into nightly/release workflow.
  2. Fixed minor bugs in wheel uploading to GCP due to one wheel changes.
  3. Removed duplicate upload code.

andy-neuma
andy-neuma reviewed Jun 25, 2024
View reviewed changes
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool.

.github/actions/nm-get-docker-tags/action.yml Outdated Show resolved Hide resolved
.github/actions/nm-get-docker-tags/action.yml Outdated Show resolved Hide resolved
.github/workflows/nm-build-test.yml Show resolved Hide resolved
.github/workflows/nm-build-test.yml Show resolved Hide resolved
.github/workflows/nm-build.yml Outdated Show resolved Hide resolved
.github/workflows/publish-docker.yml Outdated Show resolved Hide resolved
.github/workflows/publish-docker.yml Outdated Show resolved Hide resolved
andy-neuma
andy-neuma approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@andy-neuma andy-neuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

.github/actions/nm-build-docker/action.yml Outdated Show resolved Hide resolved
@dhuangnm dhuangnm merged commit bcb2bd7 into main Jun 25, 2024
28 checks passed
@dhuangnm dhuangnm deleted the adddocker branch June 25, 2024 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andy-neuma andy-neuma andy-neuma approved these changes

@dbarbuzzi dbarbuzzi Awaiting requested review from dbarbuzzi

@derekk-nm derekk-nm Awaiting requested review from derekk-nm

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuangnm @andy-neuma