Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): use m-lab/locate/v2 #49

Merged
merged 17 commits into from
Sep 17, 2024
Merged

refactor(client): use m-lab/locate/v2 #49

merged 17 commits into from
Sep 17, 2024

Conversation

bassosimone
Copy link
Member

@bassosimone bassosimone commented Sep 11, 2024

This diff modifies the client package to use m-lab/locate/v2 to fetch m-lab servers.

Closes #47.

This commit makes sure we thoroughly document how the
server works and applies some maintenance changes.

The most relevant changes are:

1. using io.ReadAll instead of ioutil.ReadAll;

2. dropping rand.Seed calls.

We can safely drop rand.Seed calls because:

> Deprecated: As of Go 1.20 there is no reason to call Seed
> with a random value. Programs that call Seed with a known value
> to get a specific sequence of results should use
> New(NewSource(seed)) to obtain a local random generator.

We use go1.20 in Dockerfile and go.mod.
@bassosimone bassosimone changed the title Locatev2 plus refactor(client): use m-lab/locate/v2 Sep 11, 2024
@bassosimone bassosimone marked this pull request as ready for review September 11, 2024 15:13
@robertodauria robertodauria self-requested a review September 16, 2024 12:54
@bassosimone bassosimone merged commit b461e19 into main Sep 17, 2024
8 of 11 checks passed
@bassosimone bassosimone deleted the locatev2-plus branch September 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use locate/v2 rather than mlab-ns
2 participants