Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #309

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Release 2.0.0 #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26c2369
Merge pull request #306 from networktocode/main
jeffkala Dec 1, 2023
2a6ea1d
Update for netmiko 4.x (#308)
pszulczewski Dec 22, 2023
26cce0e
Feature/boot swicth all (#289)
juanjtomasg Dec 22, 2023
a948452
Release 2.0.0
pszulczewski Dec 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 40 additions & 42 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
strategy:
fail-fast: true
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"] # "3.10" add back after pyeapi new release.
python-version: ["3.8", "3.11"]
runs-on: "ubuntu-20.04"
env:
PYTHON_VER: "${{ matrix.python-version }}"
Expand Down Expand Up @@ -114,49 +114,48 @@ jobs:
- "pydocstyle"
- "flake8"
- "yamllint"
# TODO: Re-enable after initial pylint issue is completed. https://github.com/networktocode/pyntc/issues/249
# pylint:
# runs-on: "ubuntu-20.04"
# strategy:
# fail-fast: true
# matrix:
# python-version: ["3.7"]
# env:
# PYTHON_VER: "${{ matrix.python-version }}"
# steps:
# - name: "Check out repository code"
# uses: "actions/checkout@v2"
# - name: "Setup environment"
# uses: "networktocode/gh-action-setup-poetry-environment@v2"
# - name: "Get image version"
# run: "echo IMAGE_VER=`poetry version -s`-py${{ matrix.python-version }} >> $GITHUB_ENV"
# - name: "Set up Docker Buildx"
# id: "buildx"
# uses: "docker/setup-buildx-action@v1"
# - name: "Load the image from cache"
# uses: "docker/build-push-action@v2"
# with:
# builder: "${{ steps.buildx.outputs.name }}"
# context: "./"
# push: false
# load: true
# tags: "${{ env.IMAGE_NAME }}:${{ env.IMAGE_VER }}"
# file: "./Dockerfile"
# cache-from: "type=gha,scope=${{ env.IMAGE_NAME }}-${{ env.IMAGE_VER }}-py${{ matrix.python-version }}"
# cache-to: "type=gha,scope=${{ env.IMAGE_NAME }}-${{ env.IMAGE_VER }}-py${{ matrix.python-version }}"
# build-args: |
# PYTHON_VER=${{ env.PYTHON_VER }}
# - name: "Debug: Show docker images"
# run: "docker image ls"
# - name: "Linting: Pylint"
# run: "poetry run invoke pylint"
# needs:
# - "build"
pylint:
runs-on: "ubuntu-20.04"
strategy:
fail-fast: true
matrix:
python-version: ["3.8"]
env:
PYTHON_VER: "${{ matrix.python-version }}"
steps:
- name: "Check out repository code"
uses: "actions/checkout@v2"
- name: "Setup environment"
uses: "networktocode/gh-action-setup-poetry-environment@v2"
- name: "Get image version"
run: "echo IMAGE_VER=`poetry version -s`-py${{ matrix.python-version }} >> $GITHUB_ENV"
- name: "Set up Docker Buildx"
id: "buildx"
uses: "docker/setup-buildx-action@v1"
- name: "Load the image from cache"
uses: "docker/build-push-action@v2"
with:
builder: "${{ steps.buildx.outputs.name }}"
context: "./"
push: false
load: true
tags: "${{ env.IMAGE_NAME }}:${{ env.IMAGE_VER }}"
file: "./Dockerfile"
cache-from: "type=gha,scope=${{ env.IMAGE_NAME }}-${{ env.IMAGE_VER }}-py${{ matrix.python-version }}"
cache-to: "type=gha,scope=${{ env.IMAGE_NAME }}-${{ env.IMAGE_VER }}-py${{ matrix.python-version }}"
build-args: |
PYTHON_VER=${{ env.PYTHON_VER }}
- name: "Debug: Show docker images"
run: "docker image ls"
- name: "Linting: Pylint"
run: "poetry run invoke pylint"
needs:
- "build"
pytest:
strategy:
fail-fast: true
matrix:
python-version: ["3.8", "3.9", "3.10", "3.11"]
python-version: ["3.8", "3.11"]
runs-on: "ubuntu-20.04"
env:
PYTHON_VER: "${{ matrix.python-version }}"
Expand Down Expand Up @@ -188,8 +187,7 @@ jobs:
- name: "Run Tests"
run: "poetry run invoke pytest"
needs:
# Remove everything but pylint once pylint is passing.
# - "pylint"
- "pylint"
- "bandit"
- "pydocstyle"
- "flake8"
Expand Down
14 changes: 14 additions & 0 deletions docs/admin/release_notes/version_2_0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# v2.0 Release Notes

## [2.0.0] 12-2023
### Added
- [308](https://github.com/networktocode/pyntc/pull/308) nxos `refresh()` method to refresh device facts.
- [289](https://github.com/networktocode/pyntc/pull/289) additional cisco_ios boot options search.

### Changed
- [308](https://github.com/networktocode/pyntc/pull/308) Updated nxos install_os and logic when waiting for device reload and improved log messages.

### Deprecated
- [308](https://github.com/networktocode/pyntc/pull/308) Deprecated netmiko argument `delay_factor` in favor of `read_timeout` as per changes in Netmiko 4.0.

Refer to this blog post for more info about changes in netmiko 4.0: https://pynet.twb-tech.com/blog/netmiko-read-timeout.html
1 change: 1 addition & 0 deletions mkdocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ nav:
- v0.19: "admin/release_notes/version_0_19.md"
- v0.20: "admin/release_notes/version_0_20.md"
- v1.0: "admin/release_notes/version_1_0.md"
- v2.0: "admin/release_notes/version_2_0.md"
- Developer Guide:
- Extending the Library: "dev/extending.md"
- Contributing to the Library: "dev/contributing.md"
Expand Down
Loading
Loading