-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for netmiko 4.x #308
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkala
approved these changes
Dec 5, 2023
pszulczewski
force-pushed
the
update_netmiko_4
branch
from
December 19, 2023 16:10
5be1a81
to
d8bfd7b
Compare
pszulczewski
force-pushed
the
update_netmiko_4
branch
2 times, most recently
from
December 19, 2023 19:52
3c5e3ef
to
b4ade42
Compare
pszulczewski
force-pushed
the
update_netmiko_4
branch
from
December 19, 2023 20:42
b4ade42
to
e841e17
Compare
pszulczewski
commented
Dec 21, 2023
pszulczewski
commented
Dec 21, 2023
pszulczewski
commented
Dec 21, 2023
pszulczewski
commented
Dec 21, 2023
pszulczewski
commented
Dec 21, 2023
This PR has been tested for software upgrade against physical devices.
Tested methods:
|
jeffkala
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell I'm good with all of this.
Post-review commit (lint) Co-authored-by: Jeff Kala <[email protected]>
pszulczewski
added a commit
that referenced
this pull request
Jan 3, 2024
* Update for netmiko 4.x (#308) * Update kwargs in nxos_device.py to fix nautobot-nornir. * Pylint updates. * Update CI for pylint py version. * Fix exceptions * Fix NXOS timeout * Add refresh facts. * Remove save() from nxos install_os as it causes error. * Update pyntc/devices/aireos_device.py Post-review commit (lint) Co-authored-by: Jeff Kala <[email protected]> --------- Co-authored-by: Jeff Kala <[email protected]> * Feature/boot swicth all (#289) Extend cisco_ios boot option lookup. --------- Co-authored-by: tomasgaj <[email protected]> * Release 2.0.0 --------- Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: juanjtomasg <[email protected]> Co-authored-by: tomasgaj <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains:
netmiko
to remove deprecateddelay_factor
in favor ofread_timeout
.Current delay_factor values have been recalculated accordingly to
compat_timeout
https://github.com/ktbyers/netmiko/blob/6bbee5fad8de1557af4ae32d98e98635e0392ae3/netmiko/base_connection.py#L1721
fast_cli
is not used anymore with read_timeout, so respective properties have been removed.Method signatures have changed,
delay_factor
has been replaced withread_timeout
, this is a braking change.fix to nxos_device kwargs, which were failing with nornir-nautobot inventory.
pylint updates, pylint has been re-enabled.