Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for netmiko 4.x #308

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Update for netmiko 4.x #308

merged 9 commits into from
Dec 22, 2023

Conversation

pszulczewski
Copy link
Contributor

@pszulczewski pszulczewski commented Dec 5, 2023

Contains:

calc_old_timeout(
                max_loops=None,
                delay_factor=3,
                loop_delay=0.2,
                old_timeout=100,
            )
300.0

calc_old_timeout(
                max_loops=None,
                delay_factor=20,
                loop_delay=0.2,
                old_timeout=100,
            )
2000.0

calc_old_timeout(
                max_loops=500,
                delay_factor=30,
                loop_delay=0.2,
                old_timeout=3600,
            )
3000.0

fast_cli is not used anymore with read_timeout, so respective properties have been removed.
Method signatures have changed, delay_factor has been replaced with read_timeout, this is a braking change.

  • fix to nxos_device kwargs, which were failing with nornir-nautobot inventory.

  • pylint updates, pylint has been re-enabled.

@pszulczewski pszulczewski changed the title Update netmiko 4 Update for netmiko 4.x Dec 5, 2023
@pszulczewski pszulczewski force-pushed the update_netmiko_4 branch 2 times, most recently from 3c5e3ef to b4ade42 Compare December 19, 2023 19:52
@pszulczewski
Copy link
Contributor Author

This PR has been tested for software upgrade against physical devices.

  • cisco_ios Catalyst 3500 and Cisco ISR4351/K9 for both: install_mode and regular mode.
  • cisco_nxos Cisco N9K-C9332C

Tested methods:

  • save()
  • file_copy()
  • install_os()

Copy link
Contributor

@jeffkala jeffkala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell I'm good with all of this.

pyntc/devices/aireos_device.py Outdated Show resolved Hide resolved
Post-review commit (lint)

Co-authored-by: Jeff Kala <[email protected]>
@pszulczewski pszulczewski merged commit 2a6ea1d into develop Dec 22, 2023
12 checks passed
pszulczewski added a commit that referenced this pull request Jan 3, 2024
* Update for netmiko 4.x (#308)

* Update kwargs in nxos_device.py to fix nautobot-nornir.

* Pylint updates.

* Update CI for pylint py version.

* Fix exceptions

* Fix NXOS timeout

* Add refresh facts.

* Remove save() from nxos install_os as it causes error.

* Update pyntc/devices/aireos_device.py

Post-review commit (lint)

Co-authored-by: Jeff Kala <[email protected]>

---------

Co-authored-by: Jeff Kala <[email protected]>

* Feature/boot swicth all (#289)

Extend cisco_ios boot option lookup.

---------

Co-authored-by: tomasgaj <[email protected]>

* Release 2.0.0

---------

Co-authored-by: Jeff Kala <[email protected]>
Co-authored-by: juanjtomasg <[email protected]>
Co-authored-by: tomasgaj <[email protected]>
@pszulczewski pszulczewski mentioned this pull request Jan 3, 2024
@pszulczewski pszulczewski linked an issue Feb 22, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finalize all pylint checks and renable pylint testing
2 participants