Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AireOS FileTransferErrors more granular #161

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Make AireOS FileTransferErrors more granular #161

merged 2 commits into from
Nov 17, 2020

Conversation

jmcgill298
Copy link
Contributor

No description provided.

@jmcgill298 jmcgill298 requested a review from mundruid November 13, 2020 22:28
mundruid
mundruid approved these changes Nov 17, 2020
View reviewed changes
Copy link

@mundruid mundruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. From a quick look these new imports (mainly FileTransferError) will need to be tested for devices other than aireos. Do you want me to open an issue or do you think this is included in issue #141: Increase test coverage?

@jmcgill298
Copy link
Contributor Author

This should be part of #141

@jmcgill298 jmcgill298 merged commit 44078c0 into develop Nov 17, 2020
@jmcgill298 jmcgill298 deleted the aireos_ft_errors branch November 17, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mundruid mundruid mundruid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcgill298 @mundruid