Skip to content

Commit

Permalink
Fix #303
Browse files Browse the repository at this point in the history
  • Loading branch information
pszulczewski committed Dec 1, 2023
1 parent 2208b8c commit 6312d88
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pyntc/devices/aireos_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ def __init__( # nosec # pylint: disable=too-many-arguments
self.native = None
self.secret = secret
self.port = int(port) if port else 22
self.delay_factor_compat = kwargs.get("delay_factor_compat", True)
self.global_delay_factor = kwargs.get("global_delay_factor", 1)
self.delay_factor = kwargs.get("delay_factor", 1)
self._connected = False
Expand Down Expand Up @@ -1096,6 +1097,7 @@ def open(self, confirm_active=True):
username=self.username,
password=self.password,
port=self.port,
delay_factor_compat=self.delay_factor_compat,
global_delay_factor=self.global_delay_factor,
secret=self.secret,
verbose=False,
Expand Down
2 changes: 2 additions & 0 deletions pyntc/devices/asa_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def __init__(self, host: str, username: str, password: str, secret="", port=None
self.secret = secret
self.port = int(port) if port else 22
self.kwargs = kwargs
self.delay_factor_compat = kwargs.get("delay_factor_compat", True)
self.global_delay_factor: int = kwargs.get("global_delay_factor", 1)
self.delay_factor: int = kwargs.get("delay_factor", 1)
self._connected = False
Expand Down Expand Up @@ -727,6 +728,7 @@ def open(self):
username=self.username,
password=self.password,
port=self.port,
delay_factor_compat=self.delay_factor_compat,
global_delay_factor=self.global_delay_factor,
secret=self.secret,
verbose=False,
Expand Down
2 changes: 2 additions & 0 deletions pyntc/devices/ios_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def __init__( # nosec
self.native = None
self.secret = secret
self.port = int(port) if port else 22
self.delay_factor_compat = kwargs.get("delay_factor_compat", True)
self.global_delay_factor = kwargs.get("global_delay_factor", 1)
self.delay_factor = kwargs.get("delay_factor", 1)
self._fast_cli = fast_cli
Expand Down Expand Up @@ -826,6 +827,7 @@ def open(self, confirm_active=True):
username=self.username,
password=self.password,
port=self.port,
delay_factor_compat=self.delay_factor_compat,
global_delay_factor=self.global_delay_factor,
secret=self.secret,
verbose=False,
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_devices/test_aireos_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -1681,3 +1681,7 @@ def test_port(aireos_device):
def test_port_none(patch):
device = AIREOSDevice("host", "user", "pass", port=None)
assert device.port == 22


def test_delay_factor_compat(aireos_device):
assert aireos_device.delay_factor_compat is True
3 changes: 3 additions & 0 deletions tests/unit/test_devices/test_asa_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def teardown(self):
def test_port(self):
assert self.device.port == 22

def test_delay_factor_compat(self):
assert self.device.delay_factor_compat is True

@mock.patch.object(ASADevice, "_get_file_system", return_value="disk0:")
def test_boot_options_dir(self, mock_boot):
self.device.native.send_command_timing.side_effect = None
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/test_devices/test_ios_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ def tearDown(self):
def test_port(self):
self.assertEqual(self.device.port, 22)

def test_delay_factor_compat(self):
self.assertEqual(self.device.delay_factor_compat, True)

def test_bad_show(self):
command = "show microsoft"
self.device.native.send_command.return_value = "Error: Microsoft"
Expand Down

0 comments on commit 6312d88

Please sign in to comment.