Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This seems a typo to me, other templates use protocol #2013

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

This seems a typo to me, other templates use protocol #2013

wants to merge 2 commits into from

Conversation

CursedEnvy
Copy link
Contributor

Easy to miss, but protocal seems a misspelling of protocol
the "display_ip_interface" template for example uses PROTOCOL_STATUS

@jvanderaa
Copy link
Contributor

This will be a breaking change.

@jvanderaa
Copy link
Contributor

Tests are failing. Probably need to update the test YAML files.

@CursedEnvy
Copy link
Contributor Author

Tests are failing. Probably need to update the test YAML files.

Aaah my bad, indeed did not think of those, I've updated them .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
breaking_change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CursedEnvy @jvanderaa